LogsDB host and timestamp mappings tests
#114001
Conversation
salvatore-campagna
added
>test
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Adding such tests is done to capture issues observed by Kibana. See #113600. |
| composed_of: ["logsdb-mappings"] | ||
|
|
||
| - match: { error.type: "illegal_argument_exception" } | ||
| - match: { error.reason: "composable template [logsdb-index-template] template after composition with component templates [logsdb-mappings] is invalid" } |
There was a problem hiding this comment.
This is not that informative.. any chance we can catch this and complain about @timestamp?
There was a problem hiding this comment.
The is just the top level exception message. There is another one saying
The timestamp field [@timestamp] does not exist in the data stream
I prefer not to change this as part of this PR...this tests just captures whatever the status is now.
There was a problem hiding this comment.
This PR is about adding tests for what current expected behavior is. We can consider improving the error message in a follow up PR. I suspect this error is data stream related and not logsdb related. There is data stream logic in place around @timestamp.
| composed_of: ["logsdb-mappings"] | ||
|
|
||
| - match: { error.type: "illegal_argument_exception" } | ||
| - match: { error.reason: "composable template [logsdb-index-template] template after composition with component templates [logsdb-mappings] is invalid" } |
There was a problem hiding this comment.
This PR is about adding tests for what current expected behavior is. We can consider improving the error message in a follow up PR. I suspect this error is data stream related and not logsdb related. There is data stream logic in place around @timestamp.
Ok I will move these tests there. |
|
@martijnvg I moved yaml rest tests to the losgdb xpack plugin. |
|
|
||
| import static org.elasticsearch.test.cluster.FeatureFlag.FAILURE_STORE_ENABLED; | ||
|
|
||
| public class LogsDBClientYamlTestSuiteIT extends ESClientYamlSuiteTestCase { |
There was a problem hiding this comment.
Why not reuse LogsdbTestSuiteIT class?
There was a problem hiding this comment.
I didn't see it was there...I had to merge main
|
@elasticmachine update branch |
|
I think this should also be back ported to 8.x? |
Yes |
salvatore-campagna
added
auto-backport
|
@elasticmachine update branch |
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Here we are testing mappings of `host` and `timestamp` fields as they are used as default fields to sort on when using LogsDB. LogsDB uses a `host.name` field mapped as a `keyword` and a `@timestamp` field, required by data streams. Some mappings throw errors as a result of incompatibilities when trying to merge object fields. Such errors are expected. (cherry picked from commit c4815b3)
Here we are testing mappings of `host` and `timestamp` fields as they are used as default fields to sort on when using LogsDB. LogsDB uses a `host.name` field mapped as a `keyword` and a `@timestamp` field, required by data streams. Some mappings throw errors as a result of incompatibilities when trying to merge object fields. Such errors are expected.
Here we are testing mappings of `host` and `timestamp` fields as they are used as default fields to sort on when using LogsDB. LogsDB uses a `host.name` field mapped as a `keyword` and a `@timestamp` field, required by data streams. Some mappings throw errors as a result of incompatibilities when trying to merge object fields. Such errors are expected. (cherry picked from commit c4815b3)
Here we are testing mappings of `host` and `timestamp` fields as they are used as default fields to sort on when using LogsDB. LogsDB uses a `host.name` field mapped as a `keyword` and a `@timestamp` field, required by data streams. Some mappings throw errors as a result of incompatibilities when trying to merge object fields. Such errors are expected.
Here we are testing mappings of
hostandtimestampfields as they areused as default fields to sort on when using LogsDB. LogsDB uses a
host.namefield mapped as akeywordand a@timestampfield, requiredby data streams. Some mappings throw errors as a result of incompatibilities
when trying to merge object fields. Such errors are expected.
See also #113600.