[otel-data] Hide 10m and 60m aggregated metrics generated for the APM UI #114042
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| version: ${xpack.oteldata.template.version} | ||
| _meta: | ||
| description: | | ||
| Default mappings that can't be changed by users for | ||
| the OpenTelemetry metrics index template installed by x-pack | ||
| managed: true | ||
| template: | ||
| mappings: | ||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_destination.10m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-10m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-10m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
|
There was a problem hiding this comment. Originally I wanted to define But as it seems, this works as well - this is also covered by tests. Just calling out to make sure there is no unwanted implication I may missed. |
||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 10m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_destination | ||
felixbarny marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_destination.1m.otel-*"] | ||
| priority: 130 | ||
| data_stream: {} | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-1m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-1m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 1m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_destination |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_destination.60m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-60m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-60m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 60m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_destination |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_summary.10m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-10m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-10m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 10m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_summary.1m.otel-*"] | ||
| priority: 130 | ||
| data_stream: {} | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-1m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-1m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 1m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_summary.60m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-60m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-60m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 60m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_transaction.10m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-10m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-10m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 10m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_transaction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_transaction.1m.otel-*"] | ||
| priority: 130 | ||
| data_stream: {} | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-1m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-1m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 1m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_transaction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_transaction.60m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-60m.otel@custom | ||
| - metrics-otel-fixed@mappings | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| - metrics-60m.otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 60m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_transaction |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the reverse. Users should be able to customize the dynamic mappings. That's why this component template needs to be imported last. This is because for dynamic templates, the first one that matches wins. Therefore, users need to be able to put a dynamic template before this in order to be able to customize how attributes are mapped dynamically. We have a test for this scenario:
elasticsearch/x-pack/plugin/otel-data/src/yamlRestTest/resources/rest-api-spec/test/20_metrics_tests.yml
Lines 112 to 148 in 3b9150d
So I think all is correctly implemented, but we'll need to change the description, and probably the name of the dynamic template. Suggestion:
ecs-tsdb@mappings(since the ip path match is coming from ECS).