[otel-data] Hide 10m and 60m aggregated metrics generated for the APM UI #114042
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_destination.10m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 10m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_destination | ||
felixbarny marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string | ||
|
There was a problem hiding this comment. Should we do something with these? We repeat them everywhere. If I remember correctly, the idea was to implement these here in the template, so people can't overwrite these. First idea would be to move them to There was a problem hiding this comment. Yes, I think it would be better to have a separate component template for these.
I think it was the opposite. Users should have the ability to customize the dynamic mappings. Therefore, when extracting this to a component template, we need to import that template after the @Custom component template. There was a problem hiding this comment. Yes, so what I mean: users should be able to change dynamic templates currently defined in So I'd move these two dynamic templates into a separate components (maybe (plus adding Does that sound ok? Happy to take suggestion on the naming |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_destination.60m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 60m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_destination | ||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_summary.10m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 10m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_summary | ||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_summary.60m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 60m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_summary | ||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_transaction.10m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 10m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_transaction | ||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-service_transaction.60m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 60m | ||
| name: | ||
| type: constant_keyword | ||
| value: service_transaction | ||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-transaction.10m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 10m | ||
| name: | ||
| type: constant_keyword | ||
| value: transaction | ||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| version: ${xpack.oteldata.template.version} | ||
| index_patterns: ["metrics-transaction.60m.otel-*"] | ||
| priority: 130 | ||
| data_stream: | ||
| hidden: true | ||
| allow_auto_create: true | ||
| _meta: | ||
| description: aggregated APM metrics template installed by x-pack | ||
| managed: true | ||
| composed_of: | ||
| - metrics@tsdb-settings | ||
| - otel@mappings | ||
| - metrics-otel@mappings | ||
| - semconv-resource-to-ecs@mappings | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| ignore_missing_component_templates: | ||
| - metrics@custom | ||
| - metrics-otel@custom | ||
| template: | ||
| settings: | ||
| index: | ||
| mode: time_series | ||
| mappings: | ||
| properties: | ||
| data_stream.type: | ||
| type: constant_keyword | ||
| value: metrics | ||
| metricset: | ||
| properties: | ||
| interval: | ||
| type: constant_keyword | ||
| value: 60m | ||
| name: | ||
| type: constant_keyword | ||
| value: transaction | ||
| dynamic_templates: | ||
| - ecs_ip: | ||
| mapping: | ||
| type: ip | ||
| path_match: [ "ip", "*.ip", "*_ip" ] | ||
| match_mapping_type: string | ||
| - all_strings_to_keywords: | ||
| mapping: | ||
| ignore_above: 1024 | ||
| type: keyword | ||
| match_mapping_type: string |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally I wanted to define
constant_keywordunderresource.attributesformetricset.intervaland underattributesformetricset.name, since that's where these are stored. But that'd again run into the usual issue of wiping out existing mapping forresource.attributes.But as it seems, this works as well - this is also covered by tests.
Just calling out to make sure there is no unwanted implication I may missed.