Skip to content

[ML] Unmuting ForecastIT » testOverflowToDisk for Windows #114807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

valeriy42
Copy link
Contributor

@valeriy42 valeriy42 commented Oct 15, 2024

Running the test on Jenkins caused flakiness in Windows. See #44609.

Since we moved to Buildkite I am unmuting this test, assuming that Buildkite is not creating such deep directory structures as Jenkins (see this comment).

We will mute this test again, if this assumption turns out to be wrong.

Closes #44609.

@valeriy42 valeriy42 added :ml Machine learning Team:ML Meta label for the ML team labels Oct 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@valeriy42 valeriy42 added the >test Issues or PRs that are addressing/adding tests label Oct 15, 2024
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriy42
Copy link
Contributor Author

@elasticsearchmachine merge main

@valeriy42
Copy link
Contributor Author

@elasticsearchmachine merge main

1 similar comment
@valeriy42
Copy link
Contributor Author

@elasticsearchmachine merge main

@valeriy42 valeriy42 merged commit 66dd432 into elastic:main Nov 25, 2024
16 checks passed
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
…4807)

Running the test on Jenkins caused flakiness in Windows. See elastic#44609.

Since we moved to Buildkite I am unmuting this test, assuming that Buildkite is not creating such deep directory structures as Jenkins (see this comment).

We will mute this test again, if this assumption turns out to be wrong.

Closes elastic#44609.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForecastIT » testOverflowToDisk failed to create temporary directory on windows
3 participants