Update Semantic Query To Handle Zero Size Responses #116277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
added
>bug
auto-backport
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
|
Hi @Mikep86, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
kderusso
reviewed
Nov 5, 2024
...inference/src/yamlRestTest/resources/rest-api-spec/test/inference/40_semantic_text_query.yml
Show resolved
Hide resolved
ioanatia
approved these changes
Nov 6, 2024
...nference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
Outdated
Show resolved
Hide resolved
benwtrent
reviewed
Nov 6, 2024
...nference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
Outdated
Show resolved
Hide resolved
|
Hi @Mikep86, I've updated the changelog YAML for you. |
jimczi
approved these changes
Nov 18, 2024
...nference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
Outdated
Show resolved
Hide resolved
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Nov 18, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Nov 18, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit 29659fd) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferenceFeatures.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java # x-pack/plugin/inference/src/yamlRestTest/resources/rest-api-spec/test/inference/40_semantic_text_query.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2024
…116983) * Update Semantic Query To Handle Zero Size Responses (#116277) (cherry picked from commit 29659fd) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferenceFeatures.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java # x-pack/plugin/inference/src/yamlRestTest/resources/rest-api-spec/test/inference/40_semantic_text_query.yml * Fix spotless error
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #116083. If a
semantic_textfield uses dense embeddings, 0-size search responses cause an error due to an invalid value forkin the underlyingknnquery. Fixed the issue by ensuring thatkis set to at least 10 in this case.