[Inference API] Add special case to inference API #116962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @maxhniebergall, I've created a changelog YAML for you. |
...org/elasticsearch/xpack/inference/services/elasticsearch/ElasticRerankerServiceSettings.java
Outdated
Show resolved
Hide resolved
docs/changelog/116962.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| pr: 116962 | |||
| summary: "[Inference API] Add special case for elastic reranker in inference API" | |||
There was a problem hiding this comment.
nit: maybe omit the [...] part
...org/elasticsearch/xpack/inference/services/elasticsearch/ElasticRerankerServiceSettings.java
Show resolved
Hide resolved
| * @param map Source map containing the config | ||
| * @return The builder | ||
| */ | ||
| public static Builder fromRequestMap(Map<String, Object> map) { |
There was a problem hiding this comment.
nit: I'm fine with keep it since it's the pattern we have, but I don't believe we use this method yet right?
There was a problem hiding this comment.
good point, we could remove this. I'm ambiguous about it. We could remove some of the constructors as well. I'm leaning towards just leaving them in.
jonathan-buttner
approved these changes
Nov 18, 2024
|
@elastimachine merge upstream |
|
@elasticmachine merge upstream |
maxhniebergall
added a commit
that referenced
this pull request
Nov 19, 2024
* Add reranker special case to inference API * Update docs/changelog/116962.yaml * Update 116962.yaml * spotless * improvements from review * Fix typo
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 19, 2024
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
* Add reranker special case to inference API * Update docs/changelog/116962.yaml * Update 116962.yaml * spotless * improvements from review * Fix typo
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
* Add reranker special case to inference API * Update docs/changelog/116962.yaml * Update 116962.yaml * spotless * improvements from review * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the reranker in the inference API