Skip to content

Term query for ES|QL #117359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Dec 6, 2024
Merged

Term query for ES|QL #117359

merged 56 commits into from
Dec 6, 2024

Conversation

tteofili
Copy link
Contributor

This PR provides a term function for ES|QL to run TermQueries.
For example:

FROM test 
| WHERE term(content,"dog")

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Nov 22, 2024
@tteofili tteofili added the :Analytics/ES|QL AKA ESQL label Nov 22, 2024
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Nov 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @tteofili, I've created a changelog YAML for you.

@getkub
Copy link

getkub commented Nov 25, 2024

Is this an alternative to 'keyword' search feature for ESQL?

@tteofili
Copy link
Contributor Author

Is this an alternative to 'keyword' search feature for ESQL?

this makes it possible to search for terms in the ES index, so somewhat similar to the keyword search feature, yes.

@ChrisHegarty
Copy link
Contributor

Adding test-release label, as we're close to merging, and wanna get more coverage since term function is snapshot only.

ChrisHegarty
ChrisHegarty approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty
Copy link
Contributor

The last CI run completed all but one test target, the test-release. It failed because of an unrelated issue, which has since been muted. The last merge with main should pick that up.

@ChrisHegarty ChrisHegarty added auto-backport Automatically create backport pull requests when merged v8.18.0 labels Dec 6, 2024
@ChrisHegarty ChrisHegarty merged commit 9160586 into elastic:main Dec 6, 2024
2 of 5 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 117359

tteofili added a commit to tteofili/elasticsearch that referenced this pull request Dec 6, 2024
@tteofili
Term query for ES|QL (elastic#117359)
284f894 
This commit adds a `term` function for ES|QL to run `TermQueries`.

For example:
FROM test | WHERE term(content, "dog")

(cherry picked from commit 9160586)
tteofili added a commit that referenced this pull request Dec 6, 2024
@tteofili
Backport Term query for ES|QL to 8.x (#117359) (#118135)
af84c61 
* Term query for ES|QL (#117359)

This commit adds a `term` function for ES|QL to run `TermQueries`.

For example:
FROM test | WHERE term(content, "dog")

(cherry picked from commit 9160586)

* Update docs/changelog/118135.yaml
@carlosdelest carlosdelest mentioned this pull request Feb 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigidellaquila luigidellaquila luigidellaquila left review comments

@ioanatia ioanatia ioanatia approved these changes

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-release Trigger CI checks against release build v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tteofili @elasticsearchmachine @getkub @ChrisHegarty @luigidellaquila @ioanatia