Skip to content

Remove unused code from PercolateQueryBuilder #118791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

javanna
Copy link
Member

@javanna javanna commented Dec 16, 2024

Support for percolate REST parameters supported for compatibility with v7 was removed in #114881 . Unused constants have been left behind.

@javanna javanna added >refactoring :Search Foundations/Search Catch all for Search Foundations v9.0.0 labels Dec 16, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Dec 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javanna javanna merged commit 8793248 into elastic:main Dec 17, 2024
16 checks passed
@javanna javanna deleted the refactoring/percolate_query_builder_unused branch December 17, 2024 10:22
@javanna
Copy link
Member Author

javanna commented Dec 17, 2024

thanks @cbuescher !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>refactoring :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants