Skip to content

Add missing ProcessBuilder.start entitlements test #119100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Dec 19, 2024

Follow-on from #119010.

In that PR, I commented out all the tests for instance methods on the basis that instance methods are hard to test if we're forbidden from creating the required instances. However, my reasoning was flawed for two reasons:

  1. we've now lifted the ban on creating those instances, and
  2. we were never forbidden from creating a ProcessBuilder in the first place.

@prdoyle prdoyle added >non-issue :Core/Infra/Core Core issues without another label auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Dec 19, 2024
@prdoyle prdoyle self-assigned this Dec 19, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Dec 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@prdoyle prdoyle enabled auto-merge (squash) December 19, 2024 16:12
@prdoyle prdoyle requested a review from rjernst December 19, 2024 16:45
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle prdoyle merged commit 7304418 into elastic:main Dec 19, 2024
16 checks passed
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Dec 19, 2024
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

@prdoyle prdoyle deleted the more-process-entitlements branch December 19, 2024 19:21
navarone-feekery pushed a commit to navarone-feekery/elasticsearch that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants