Skip to content

Enable query rewrites on the coordinator for ESQL #119667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Enable query rewrites on the coordinator for ESQL #119667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b40e54
Enable query rewrites on the coordinator for ESQL
ioanatia Jan 7, 2025
b65c5de
[CI] Auto commit changes from spotless
elasticsearchmachine Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .../plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/QueryBuilderResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import org.elasticsearch.index.query.Rewriteable;
import org.elasticsearch.search.SearchService;
import org.elasticsearch.transport.TransportService;
import org.elasticsearch.xpack.esql.action.EsqlCapabilities;
import org.elasticsearch.xpack.esql.core.util.Holder;
import org.elasticsearch.xpack.esql.expression.function.fulltext.FullTextFunction;
import org.elasticsearch.xpack.esql.plan.logical.EsRelation;
Expand Down Expand Up @@ -59,12 +58,6 @@ public void resolveQueryBuilders(
ActionListener<Result> listener,
BiConsumer<LogicalPlan, ActionListener<Result>> callback
) {
// TODO: remove once SEMANTIC_TEXT_TYPE is enabled outside of snapshots
if (false == EsqlCapabilities.Cap.SEMANTIC_TEXT_TYPE.isEnabled()) {
callback.accept(plan, listener);
return;
}

if (plan.optimized() == false) {
listener.onFailure(new IllegalStateException("Expected optimized plan before query builder rewrite."));
return;
Expand Down