Skip to content

Emit process_nanos from LookupOperator #120694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

idegtiarenko
Copy link
Contributor

@idegtiarenko idegtiarenko commented Jan 23, 2025

While profiling esql execution I noticed that most of the operators emit process_nanos except LookupOperator that emits total_time_in_millis & total_time:

...
          {
            "operator": "LuceneSourceOperator[maxPageSize = 1236, remainingDocs = 997]",
            "status": {
              "processed_slices": 1,
              "processed_queries": [
                "*:*"
              ],
              "processed_shards": [
                "base:0"
              ],
              "processing_nanos": 143595, <------
              "slice_index": 0,
              "total_slices": 1,
              "pages_emitted": 3,
              "slice_min": 0,
              "slice_max": 0,
              "current": 2147483647,
              "rows_emitted": 3
            }
          },
          {
            "operator": "ValuesSourceReaderOperator[fields = [key, value, value.keyword]]",
            "status": {
              "readers_built": {
                "key:column_at_a_time:BlockDocValuesReader.SingletonLongs": 3,
                "stored_fields[requires_source:true, fields:0, sequential: false]": 3,
                "value.keyword:column_at_a_time:BlockDocValuesReader.SingletonOrdinals": 3,
                "value:column_at_a_time:null": 3,
                "value:row_stride:BlockSourceReader.Bytes": 3
              },
              "process_nanos": 1135976, <------
              "pages_processed": 3,
              "rows_received": 3,
              "rows_emitted": 3
            }
          },
          {
            "operator": "ProjectOperator[projection = [1, 2, 3]]",
            "status": {
              "process_nanos": 40508, <------
              "pages_processed": 3,
              "rows_received": 3,
              "rows_emitted": 3
            }
          },
...
          {
            "operator": "LookupOperator[index=languages input_type=LONG match_field=key load_fields=[language{f}#38, language.keyword{f}#39] inputChannel=0]",
            "status": {
              "received_pages": 2,
              "completed_pages": 2,
              "total_time_in_millis": 6, <------
              "total_time": "6ms",        <------
              "emitted_pages": 3,
              "total_terms": 3
            }
          },
...

This change updates LookupOperator to emit process_nanos as well.

@idegtiarenko idegtiarenko added >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Jan 23, 2025
@idegtiarenko idegtiarenko requested a review from nik9000 January 23, 2025 08:20
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
@idegtiarenko idegtiarenko removed auto-backport Automatically create backport pull requests when merged v8.19.0 labels Feb 3, 2025
# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
@idegtiarenko idegtiarenko merged commit efb890b into elastic:main Feb 7, 2025
17 checks passed
@idegtiarenko idegtiarenko deleted the profiler_emit_nanos branch February 7, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants