Fix matching of half_float and scaled_float values in LogsDB tests #121098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkts
added
>test
kkrik-es
approved these changes
Jan 29, 2025
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 29, 2025
…121098) (#121140) Co-authored-by: Kostas Krikellas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceMatchesExactlycontained check forsynthetic_source_keep: "arrays"but in presence of nested objects it does not actually mean that source is exact. This PR removessourceMatchesExactlycompletely since field specific matchers can properly handle mixed exact and non-exact values now.