-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ES|QL] Add aggregate metric double feature flag to its capability #121318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
limotova
merged 1 commit into
elastic:main
from
limotova:put-feature-flag-under-aggregate-metric-double-esql-capability
Jan 30, 2025
Merged
[ES|QL] Add aggregate metric double feature flag to its capability #121318
limotova
merged 1 commit into
elastic:main
from
limotova:put-feature-flag-under-aggregate-metric-double-esql-capability
Jan 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Merging because test failures appear unrelated and this should fix a different CI failure |
limotova
added a commit
to limotova/elasticsearch
that referenced
this pull request
Jan 30, 2025
…lastic#121318) AggregateMetricDouble should be behind a feature flag but on release builds it was getting added when it should not have been. This commit addresses that bug.
This was referenced Jan 30, 2025
limotova
added a commit
to limotova/elasticsearch
that referenced
this pull request
Jan 30, 2025
…lastic#121318) AggregateMetricDouble should be behind a feature flag but on release builds it was getting added when it should not have been. This commit addresses that bug.
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jan 30, 2025
…lastic#121318) AggregateMetricDouble should be behind a feature flag but on release builds it was getting added when it should not have been. This commit addresses that bug.
saikatsarkar056
pushed a commit
to saikatsarkar056/elasticsearch
that referenced
this pull request
Jan 31, 2025
…lastic#121318) AggregateMetricDouble should be behind a feature flag but on release builds it was getting added when it should not have been. This commit addresses that bug.
bpintea
pushed a commit
to bpintea/elasticsearch
that referenced
this pull request
Jan 31, 2025
…lastic#121318) AggregateMetricDouble should be behind a feature flag but on release builds it was getting added when it should not have been. This commit addresses that bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
auto-backport
Automatically create backport pull requests when merged
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
>test
Issues or PRs that are addressing/adding tests
test-release
Trigger CI checks against release build
v8.18.1
v8.19.0
v9.0.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.