Skip to content

[ES|QL] Add aggregate metric double feature flag to its capability #121318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

limotova
Copy link
Contributor

@limotova limotova commented Jan 30, 2025

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.

@limotova limotova added the >test Issues or PRs that are addressing/adding tests label Jan 30, 2025
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@limotova limotova added auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 v8.19.0 labels Jan 30, 2025
@dnhatn dnhatn added v8.18.1 v9.0.0 test-release Trigger CI checks against release build and removed v8.18.0 v9.0.0 labels Jan 30, 2025
@limotova limotova marked this pull request as ready for review January 30, 2025 21:26
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 30, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@limotova
Copy link
Contributor Author

Merging because test failures appear unrelated and this should fix a different CI failure

@limotova limotova merged commit 6cf3835 into elastic:main Jan 30, 2025
14 of 19 checks passed
@limotova limotova deleted the put-feature-flag-under-aggregate-metric-double-esql-capability branch January 30, 2025 21:54
limotova added a commit to limotova/elasticsearch that referenced this pull request Jan 30, 2025
…lastic#121318)

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.
limotova added a commit to limotova/elasticsearch that referenced this pull request Jan 30, 2025
…lastic#121318)

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0
8.18
8.x

smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jan 30, 2025
…lastic#121318)

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.
saikatsarkar056 pushed a commit to saikatsarkar056/elasticsearch that referenced this pull request Jan 31, 2025
…lastic#121318)

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.
limotova added a commit that referenced this pull request Jan 31, 2025
…121318) (#121342)

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.
limotova added a commit that referenced this pull request Jan 31, 2025
…121318) (#121343)

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.
limotova added a commit that referenced this pull request Jan 31, 2025
…121318) (#121344)

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.
bpintea pushed a commit to bpintea/elasticsearch that referenced this pull request Jan 31, 2025
…lastic#121318)

AggregateMetricDouble should be behind a feature flag but on release
builds it was getting added when it should not have been. This commit
addresses that bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v8.18.1 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants