[ML] Unmute InferenceCrudIT tests #121461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>test
| @@ -191,9 +191,6 @@ tests: | |||
| - class: org.elasticsearch.reservedstate.service.FileSettingsServiceTests | |||
| method: testProcessFileChanges | |||
| issue: https://github.com/elastic/elasticsearch/issues/115280 | |||
| - class: org.elasticsearch.xpack.inference.InferenceCrudIT | |||
| method: testSupportedStream | |||
| issue: https://github.com/elastic/elasticsearch/issues/113430 | |||
There was a problem hiding this comment.
This was actually fixed in this PR: #118481
| @@ -400,9 +397,6 @@ tests: | |||
| - class: org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT | |||
| method: test {date_nanos.Bucket Date nanos by 10 minutes} | |||
| issue: https://github.com/elastic/elasticsearch/issues/120162 | |||
| - class: org.elasticsearch.xpack.inference.InferenceCrudIT | |||
| method: testGetServicesWithCompletionTaskType | |||
| issue: https://github.com/elastic/elasticsearch/issues/119959 | |||
There was a problem hiding this comment.
This test doesn't live in InferenceCrudIT anymore. It lives here: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceGetServicesIT.java#L112
I believe the issue was related to the EIS feature flag which no longer exists.
|
Pinging @elastic/ml-core (Team:ML) |
|
@elasticmachine merge upstream |
|
There are no new commits on the base branch. |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Jan 31, 2025
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unmutes some
InferenceCrudITtests for 8.x only (they aren't muted in main). These have actually been fixed previously but I forgot to unmute the tests.