Remove unnecessary FeatureService dependencies #121496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of unused fields for this thing. Also, more of its methods can just be made static to avoid a dependency.
original-brownbear
added
>non-issue
:Core/Infra/Node Lifecycle
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Change looks fine, but I want to be sure we aren't missing some reason they need to be instance methods. @thecoop was there a need for feature service to be passed around? based on this change it's unclear if it needs to even be injected.
|
The extra |
rjernst
approved these changes
Feb 7, 2025
|
Thanks Ryan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of unused fields for this thing. Also, more of its methods
can just be made static to avoid a dependency.
(+ some adjacent unused constructor arg removals)