Skip to content

[ML] Add deprecation warning for flush API #121667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 7, 2025

Conversation

valeriy42
Copy link
Contributor

@valeriy42 valeriy42 commented Feb 4, 2025

The anomaly detection job flush API is deprecated since it is only required for the post data API, which was deprecated since 7.11.0.

Closes #121506

@valeriy42 valeriy42 added >deprecation :ml Machine learning Team:ML Meta label for the ML team v9.1.0 labels Feb 4, 2025
@valeriy42 valeriy42 self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Documentation preview:

Copy link
Contributor

github-actions bot commented Feb 4, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@elasticsearchmachine
Copy link
Collaborator

Hi @valeriy42, I've created a changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

github-actions bot commented Feb 4, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@valeriy42 valeriy42 requested a review from szabosteve February 4, 2025 14:47
Copy link
Contributor

github-actions bot commented Feb 4, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@valeriy42
Copy link
Contributor Author

I will hold off merging this PR until the documentation migration is finished.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please consult the exact wording of this message with the docs team.
I'm not sure if it is obvious to the user what deprecating flush has to do with datafeed being mandatory.

@elasticsearchmachine
Copy link
Collaborator

Hi @valeriy42, I've updated the changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@szabosteve
Copy link
Contributor

@valeriy42 This PR (opened in the elasticsearch/specification repo) is enough to mark the API as deprecated in the docs. Documentation for 9.0 and above will live in the Markdown docs system (docs-content repo). And the API reference docs are available here. For this reason, you don't need to change the docs as part of this PR because the docs only for 8.x versions remain in asciidoc, and your changes target above 9.0. Please let me know if you have any questions, or if I explained the situation poorly. If I had more time, I would have written a shorter, clearer message. :)

Copy link
Contributor

github-actions bot commented Feb 6, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@valeriy42 valeriy42 merged commit f1b1983 into elastic:main Feb 7, 2025
17 checks passed
@mosche mosche added the v9.0.1 label Mar 18, 2025
mosche pushed a commit to mosche/elasticsearch that referenced this pull request Mar 18, 2025
The anomaly detection job flush API is deprecated since it is only required for the post data API, which was deprecated since 7.11.0.

Closes elastic#121506

(cherry picked from commit f1b1983)
@mosche
Copy link
Contributor

mosche commented Mar 18, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Mar 18, 2025
The anomaly detection job flush API is deprecated since it is only required for the post data API, which was deprecated since 7.11.0.

Closes #121506

(cherry picked from commit f1b1983)

Co-authored-by: Valeriy Khakhutskyy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>deprecation :ml Machine learning Team:ML Meta label for the ML team v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Deprecate _flush API in 9.1
5 participants