-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ML] Add deprecation warning for flush API #121667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview: |
It looks like this PR modifies one or more |
Hi @valeriy42, I've created a changelog YAML for you. Note that since this PR is labelled |
Pinging @elastic/ml-core (Team:ML) |
It looks like this PR modifies one or more |
It looks like this PR modifies one or more |
I will hold off merging this PR until the documentation migration is finished. |
It looks like this PR modifies one or more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please consult the exact wording of this message with the docs team.
I'm not sure if it is obvious to the user what deprecating flush
has to do with datafeed being mandatory.
Hi @valeriy42, I've updated the changelog YAML for you. Note that since this PR is labelled |
It looks like this PR modifies one or more |
@valeriy42 This PR (opened in the elasticsearch/specification repo) is enough to mark the API as deprecated in the docs. Documentation for 9.0 and above will live in the Markdown docs system (docs-content repo). And the API reference docs are available here. For this reason, you don't need to change the docs as part of this PR because the docs only for 8.x versions remain in asciidoc, and your changes target above 9.0. Please let me know if you have any questions, or if I explained the situation poorly. If I had more time, I would have written a shorter, clearer message. :) |
It looks like this PR modifies one or more |
The anomaly detection job flush API is deprecated since it is only required for the post data API, which was deprecated since 7.11.0. Closes elastic#121506 (cherry picked from commit f1b1983)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
The anomaly detection job flush API is deprecated since it is only required for the post data API, which was deprecated since 7.11.0. Closes #121506 (cherry picked from commit f1b1983) Co-authored-by: Valeriy Khakhutskyy <[email protected]>
The anomaly detection job flush API is deprecated since it is only required for the post data API, which was deprecated since 7.11.0.
Closes #121506