Support file entitlements relative to the user's home directory #122724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
mosche
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
commented
Feb 17, 2025
...nt/src/main/java/org/elasticsearch/entitlement/initialization/EntitlementInitialization.java
Show resolved
Hide resolved
ldematte
approved these changes
Feb 17, 2025
| return BaseDir.DATA; | ||
| } | ||
| throw new PolicyValidationException("invalid relative directory: " + baseDir + ", valid values: [config, data]"); | ||
| return switch (baseDir) { |
There was a problem hiding this comment.
This is nice IMO, but I think it'll fail backport (8.x is not at this Java lang level IIRC). Just a warning.
There was a problem hiding this comment.
8.17 is at a minimum of Java 17 (based on https://www.elastic.co/support/matrix), so would expect this to be safe for backports as well
mosche
added
auto-merge-without-approval
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 17, 2025
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 17, 2025
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2025
mosche
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support file entitlements relative to the user's home directory.
Relates to ES-10843