Refactor SnapshotInfo dataflow in finalization
#124336
Merged
+21
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to have a `SnapshotInfo` consumer to run at the end of finalization, we only pass it the value we already calculated earlier. This replaces it with a bare `Runnable` instead.
DaveCTurner
added
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Small change arising from work towards a fix for #108907 - snapshot finalization is a bit of a tangle of code split across |
|
I might change the commit message to say "Refactor" instead of "Clean up" |
DaveCTurner
changed the title
SnapshotInfo dataflow in finalizationSnapshotInfo dataflow in finalization
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 7, 2025
There's no need to have a `SnapshotInfo` consumer to run at the end of finalization, we only pass it the value we already calculated earlier. This replaces it with a bare `Runnable` instead.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
There's no need to have a `SnapshotInfo` consumer to run at the end of finalization, we only pass it the value we already calculated earlier. This replaces it with a bare `Runnable` instead.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
There's no need to have a `SnapshotInfo` consumer to run at the end of finalization, we only pass it the value we already calculated earlier. This replaces it with a bare `Runnable` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to have a
SnapshotInfoconsumer to run at the end offinalization, we only pass it the value we already calculated earlier.
This replaces it with a bare
Runnableinstead.