Skip to content

Unmute StoreRecoveryTest#testAddIndices #124548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Unmute StoreRecoveryTest#testAddIndices #124548

merged 1 commit into from
Mar 11, 2025

Conversation

fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Mar 11, 2025

This is fixed by #123676

Closes #124104

@fcofdez fcofdez added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. v9.0.0 Team:Distributed Indexing Meta label for Distributed Indexing team labels Mar 11, 2025
@fcofdez fcofdez requested a review from kingherc March 11, 2025 10:22
@fcofdez
Copy link
Contributor Author

fcofdez commented Mar 11, 2025

I tested this in my windows desktop and the test passed 100s of times.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

kingherc
kingherc approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Else it will be muted again.

@fcofdez fcofdez merged commit eb881f4 into elastic:9.0 Mar 11, 2025
16 checks passed
@fcofdez fcofdez mentioned this pull request Mar 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingherc kingherc kingherc approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Store Issues around managing unopened Lucene indices. If it touches Store.java, this is a likely label. Team:Distributed Indexing Meta label for Distributed Indexing team >test Issues or PRs that are addressing/adding tests v9.0.0 v9.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fcofdez @elasticsearchmachine @kingherc