Skip to content

Include stack trace in Not Entitled warning #124895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2025

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Mar 14, 2025

We can't always trust all environments to capture the stack trace for these, and we sometimes want them. Let's take matters into our own hands.

@prdoyle prdoyle added >non-issue auto-backport Automatically create backport pull requests when merged test-entitlements v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 14, 2025
@prdoyle prdoyle self-assigned this Mar 14, 2025
@prdoyle prdoyle requested a review from a team as a code owner March 14, 2025 15:34
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@prdoyle
Copy link
Contributor Author

prdoyle commented Mar 14, 2025

Hmm, I suppose the log message is a bit redundant, given that it will also appear in the exception itself.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prdoyle
Copy link
Contributor Author

prdoyle commented Mar 14, 2025

FYI this will conflict with #124896.

@prdoyle prdoyle enabled auto-merge (squash) March 14, 2025 17:34
@prdoyle prdoyle disabled auto-merge March 14, 2025 18:07
@prdoyle prdoyle enabled auto-merge (squash) March 14, 2025 18:07
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18
8.x
9.0

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 14, 2025
* Include stack trace in Not Entitled warning

* Remove redundant log message text
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 14, 2025
* Include stack trace in Not Entitled warning

* Remove redundant log message text
elasticsearchmachine pushed a commit that referenced this pull request Mar 14, 2025
* Include stack trace in Not Entitled warning

* Remove redundant log message text
elasticsearchmachine pushed a commit that referenced this pull request Mar 14, 2025
* Include stack trace in Not Entitled warning

* Remove redundant log message text
elasticsearchmachine pushed a commit that referenced this pull request Mar 14, 2025
* Include stack trace in Not Entitled warning

* Remove redundant log message text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants