-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce qa
subprojects of :modules:repository-s3
#126274
Merged
elasticsearchmachine
merged 1 commit into
elastic:main
from
DaveCTurner:2025/04/04/repository-s3-qa-projects
Apr 4, 2025
Merged
Introduce qa
subprojects of :modules:repository-s3
#126274
elasticsearchmachine
merged 1 commit into
elastic:main
from
DaveCTurner:2025/04/04/repository-s3-qa-projects
Apr 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we have some special-case test classes in `:modules:repository-s3` within the same source root as the regular tests, with some trickery to define separate Gradle tasks to run them with their special-case configs. This commit simplifies the build by just moving each of these classes into its own Gradle project.
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
breskeby
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 4, 2025
Today we have some special-case test classes in `:modules:repository-s3` within the same source root as the regular tests, with some trickery to define separate Gradle tasks to run them with their special-case configs. This commit simplifies the build by just moving each of these classes into its own Gradle project.
💚 Backport successful
|
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 4, 2025
Relates elastic#126274 Closes elastic#126301 Closes elastic#126302 Closes elastic#126303 Closes elastic#126304 Closes elastic#126305 Closes elastic#126306
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 4, 2025
Relates elastic#126274 Closes elastic#126301 Closes elastic#126302 Closes elastic#126303 Closes elastic#126304 Closes elastic#126305 Closes elastic#126306
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
…6277) Today we have some special-case test classes in `:modules:repository-s3` within the same source root as the regular tests, with some trickery to define separate Gradle tasks to run them with their special-case configs. This commit simplifies the build by just moving each of these classes into its own Gradle project.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
Today we have some special-case test classes in `:modules:repository-s3` within the same source root as the regular tests, with some trickery to define separate Gradle tasks to run them with their special-case configs. This commit simplifies the build by just moving each of these classes into its own Gradle project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
Team:Distributed Coordination
Meta label for Distributed Coordination team
>test
Issues or PRs that are addressing/adding tests
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have some special-case test classes in
:modules:repository-s3
within the same source root as the regular tests, with some
trickery to define separate Gradle tasks to run them with their
special-case configs. This commit simplifies the build by just moving
each of these classes into its own Gradle project.