Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce qa subprojects of :modules:repository-s3 #126274

Conversation

DaveCTurner
Copy link
Contributor

Today we have some special-case test classes in :modules:repository-s3
within the same source root as the regular tests, with some
trickery to define separate Gradle tasks to run them with their
special-case configs. This commit simplifies the build by just moving
each of these classes into its own Gradle project.

Today we have some special-case test classes in `:modules:repository-s3`
within the same source root as the regular tests, with some
trickery to define separate Gradle tasks to run them with their
special-case configs. This commit simplifies the build by just moving
each of these classes into its own Gradle project.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.19.0 v9.1.0 labels Apr 4, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Apr 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Apr 4, 2025
@elasticsearchmachine elasticsearchmachine merged commit 7402dfd into elastic:main Apr 4, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/04/04/repository-s3-qa-projects branch April 4, 2025 10:29
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 4, 2025
Today we have some special-case test classes in `:modules:repository-s3`
within the same source root as the regular tests, with some trickery to
define separate Gradle tasks to run them with their special-case
configs. This commit simplifies the build by just moving each of these
classes into its own Gradle project.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 4, 2025
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2025
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 4, 2025
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2025
…6277)

Today we have some special-case test classes in `:modules:repository-s3`
within the same source root as the regular tests, with some trickery to
define separate Gradle tasks to run them with their special-case
configs. This commit simplifies the build by just moving each of these
classes into its own Gradle project.
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2025
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Apr 9, 2025
Today we have some special-case test classes in `:modules:repository-s3`
within the same source root as the regular tests, with some trickery to
define separate Gradle tasks to run them with their special-case
configs. This commit simplifies the build by just moving each of these
classes into its own Gradle project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants