[Profiling] Don't use synthetic source for symbolization queues #126278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
added
>bug
:UniversalProfiling/Application
elasticsearchmachine
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
elasticsearchmachine
added
the
external-contributor
christos68k
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using synthetic source for the ephemeral symbolization queue indices
profiling-sq-leafframesandprofiling-sq-executablesisn't needed, and even consumes CPU cycles unnecessarily when reading data.A secondary issue is a side-effect of using synthetic source: in responses, the field names inside
_sourceare "nested". If synthetic source is disabled, these field names are "dotted".Since ES 8.17, synthetic source is automatically disabled outside enterprise subscriptions.
This forces us to maintain two code pathes when parsing responses.
Switching away from using synthetic source allows having only one code path for parsing.