[ML] Refactoring inference API non-streaming response validation error object check #126725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
Apr 14, 2025
💚 Backport successful
|
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Apr 14, 2025
…r object check (elastic#126725) * Refactoring so that non-streaming does not check for error object * Fixing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the response validation logic to only check for the presence of an error object in a streaming request logic. This avoids having to perform parse attempt for an error object on each request in the non-stream case where we expect most requests to succeed.
The error object is still parsed when the response handler encounters a non-200 status code.