[ES|QL] COMPLETION command logical plan optimizer #126763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
afoucret
requested review from
carlosdelest,
ioanatia,
ChrisHegarty,
fang-xing-esql and
svilen-mihaylov-elastic
carlosdelest
approved these changes
Apr 14, 2025
| @@ -238,6 +245,53 @@ public void testSelectivelyPushDownFilterPastFunctionAgg() { | |||
| assertEquals(expected, new PushDownAndCombineFilters().apply(fb)); | |||
| } | |||
|
|
|||
| // from ... | where a > 1 | COMPLETION "some prompt" WITH reranker AS completion | where b < 2 and match(completion, some text) | |||
| // => ... | where a > 1 AND b < 2| COMPLETION "some prompt" WITH reranker AS completion | match(completion, some text) | |||
| public void testPushDownFilterPastCompletion() { | |||
There was a problem hiding this comment.
I might have missed this - is the PushDownAndCombineLimits change being tested?
There was a problem hiding this comment.
Added some test for PushDownAndCombineLimits (it is wild but none were created for other commands)
There was a problem hiding this comment.
The LogicalPlanOptimizerTests have testCombineLimits and testMultipleCombineLimits, but indeed, I don't immediately see tests for the case where there are compatible plans between the two limits. Thanks a lot for the added tests.
afoucret
force-pushed
the
esql-completion-logical-plan-optimizer
branch
from
ee35f39 to
4eab7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
COMPLETIONcommand is expected to be costly because it is doing an inference for each row of the dataset.This PR tries to limit the number of rows to process by applying the same logical plan than others
GeneratingPlan(Eval,Enrich,RegexExtract, ...):COMPLETIONcommand when possibleCOMPLETIONcommand when possibleWork for the completion command is tracked in: #124405
PS: the command is available only for snapshot build.