Modify search request to incorporate query refactoring

[colings86]

No description provided.

[s1monw]

I wonder if we should just drop this and push this to the caller instead?

[s1monw]

I left a bunch of inline comments but this looks awesome!

[colings86]

@s1monw thanks for the review. I have push an update although this is far from finished. I also left a few replies to your comments. Next I'll write a unit test for this class to ensure its serialising and deserialising to/from JSON and the transport layer correctly and then I'll set to work plugging this into the search action

[s1monw]

this looks pretty neat dude!

[colings86]

@s1monw @javanna I pushed some more commits to this. It should now compile and the tests should pass but there is quite a bit more work to be done:

1. At the moment the SearchSourceBuilder is only used to generate the JSON request bytes to pass into the SearchRequest. We need to embed SearchSourceBuilder in the SearchRequest and then pass it to the ShardLocalSearchRequest and use it there to execute the search (parsing the bits that are currently stored as BytesReferences)
2. There are some muted and commented out tests (all have NORELEASE comments on them) which need to be got working
3. The RestDeleteByQueryAction needs fixing to parse the JSON body of the deleteByQuery request into a QueryBuilder
4. The NewSearchSourceBuilderTests class (to be renamed later) has some NORELEASE comments where we need to add code to randomly generate aggregations, suggests, etc.

[s1monw]

@colings86 can you push it to a public branch so we can all work on it?

[colings86]

@s1monw pushed a public branch here: https://github.com/elastic/elasticsearch/tree/feature/search-request-refactoring

[colings86]

This has been superseded by #13752