Remove "uninverted" and "binary" fielddata support for numeric and boolean fields. #14082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| private static final IndexFieldData.Builder MISSING_DOC_VALUES_BUILDER = new IndexFieldData.Builder() { | ||
| @Override | ||
| public IndexFieldData<?> build(Index index, Settings indexSettings, MappedFieldType fieldType, IndexFieldDataCache cache, CircuitBreakerService breakerService, MapperService mapperService) { | ||
| throw new IllegalStateException("Fielddata can't be loaded on field [" + fieldType.names().fullName() |
There was a problem hiding this comment.
I'm not sure what this message means - maybe better to say that fielddata is unsupported for these types and to use docvalues instead?
|
@nik9000 I pushed a new commit. |
| @@ -238,4 +188,67 @@ public void onRemoval(ShardId shardId, MappedFieldType.Names fieldNames, FieldDa | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| public void testRequireDocValuesOnLongs() { | |||
| ThreadPool threadPool = new ThreadPool("random_threadpool_name"); | |||
There was a problem hiding this comment.
These seem copy-and-paste-ish. Can you make a method that does the assertion and just call it for all the types? Or do it in a for loop or something?
|
Left a minor comment - it looks pretty good to me otherwise. Its nice to see this code go. |
…olean fields. Numeric and boolean fields have doc values enabled by default as of elasticsearch 2.0. This commit removes support for uninverted/in-memory fielddata, as well as numeric fields encoded in binary doc values which was the way that elasticsearch stored doc values in a Lucene index before the 1.4 release. As a consequence, you will only be able to sort and aggregate on numeric and boolean fields in Elasticsearch 3.0 if doc values have not been switched off.
jpountz
force-pushed
the
remove/uninverted_numeric_fielddata
branch
from
8557bb8 to
76231c8
Compare
jpountz
added a commit
that referenced
this pull request
Oct 21, 2015
…ddata Remove "uninverted" and "binary" fielddata support for numeric and boolean fields.
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numeric and boolean fields have doc values enabled by default as of
elasticsearch 2.0. This commit removes support for uninverted/in-memory
fielddata, as well as numeric fields encoded in binary doc values which was
the way that elasticsearch stored doc values in a Lucene index before the
1.4 release.
As a consequence, you will only be able to sort and aggregate on numeric and
boolean fields in Elasticsearch 3.0 if doc values have not been switched off.
Relates #14113