Skip to content

Ensure searcher is release if wrapping fails #14107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2015

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Oct 14, 2015

Today we leak an index searcher if we fail to wrap the seacher in
IndexShard. This commit ensures that the seacher is released if the wrapper
throws an exception.

This commit also restructures some test to be more atomic and only test a single
feature / attribute of the wrapper.

Today we leak an index searcher if we fail to wrap the seacher in
IndexShard. This commit ensures that the seacher is released if the wrapper
throws an exception.

This commit also restructures some test to be more atomic and only test a single
feature / attribute of the wrapper.
@jpountz
Copy link
Contributor

jpountz commented Oct 14, 2015

👍

s1monw added a commit that referenced this pull request Oct 14, 2015
…lure

Ensure searcher is release if wrapping fails
@s1monw s1monw merged commit 461ce98 into elastic:master Oct 14, 2015
@s1monw s1monw deleted the release_searcher_on_wrapper_failure branch October 14, 2015 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants