Refactor ShardFailure listener infrastructure #14206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we leak the notion of an engine outside of the shard abstraction which is not desirable. This commit refactors the infrastrucutre to use use already existing interfaces to communicate if a shard has failed and prevents engine private classes to be implemented on a higher level. This change is purely cosmentical...
| @@ -167,7 +166,7 @@ | |||
| private final MeanMetric refreshMetric = new MeanMetric(); | |||
| private final MeanMetric flushMetric = new MeanMetric(); | |||
|
|
|||
| private final ShardEngineFailListener failedEngineListener = new ShardEngineFailListener(); | |||
| private final ShardEngineFailListener engineEventListener = new ShardEngineFailListener(); | |||
There was a problem hiding this comment.
nit: since we're moving away from the word fail in the name, can we rename ShardEngineFailListener to ShardEngineEventListener
There was a problem hiding this comment.
the shard end was not intended to be generic... I left that in here on purpose
There was a problem hiding this comment.
ah wrong I misunderstood... fixing
|
LGTM. Left one minor comment (next to trivial stuff) about null protection in IndicesClusterStateService |
|
pushed a new commit adressing all comments and I also improved the situation if indexShard is null |
| public static final class ShardFailure { | ||
| public final ShardRouting routing; | ||
| public final String reason; | ||
| @Nullable |
|
LGTM. Thx @s1monw |
s1monw
added a commit
that referenced
this pull request
Oct 21, 2015
Refactor ShardFailure listener infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we leak the notion of an engine outside of the shard abstraction
which is not desirable. This commit refactors the infrastrucutre to use
use already existing interfaces to communicate if a shard has failed and
prevents engine private classes to be implemented on a higher level.
This change is purely cosmentical...