-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[DOCS] document replacement for search exists #14393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@clintongormley can you have a look please? also, I am not sure where this new section should go, probably not where I added it :) |
is the `total_hits` field that tells us how many documents matched the query, | ||
before the query was terminated. Also if the query was terminated early, the | ||
`terminated_early` flag will be set to `true` in the response. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm being captain Obvious, but it could be worth just saying that a total hit count equal to 0 means that there are no matches, while a count greater than 0 means that there are matches?
7c20db0
to
b1201fc
Compare
@jpountz pushed a new commit, thanks for having a look. |
$ curl -XGET 'http://localhost:9200/_search?q=tag:wow&size=0&terminate_after=1' | ||
-------------------------------------------------- | ||
|
||
The response will not contain any hit as the `size` was set to `0`. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any hitS
Yeah, its current position feels too important. How about adding a section called |
b1201fc
to
a17221a
Compare
@clintongormley I pushed a new commit, can you double check please? |
LGTM |
Relates to elastic#13910 Closes elastic#14393
a17221a
to
ca980b7
Compare
Search exists api was removed from master and deprecated in 2.x. With this PR we document how the same can be achieved using the search api.
Relates to #13910