Add CONTAINS relation to geo_shape query #14810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
>feature
:Analytics/Geo
| @@ -323,6 +324,34 @@ public void testShapeFilterWithRandomGeoCollection() throws Exception { | |||
| assertHitCount(result, 1); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can we have a unit test instead of an integration test?
There was a problem hiding this comment.
added commit that refactors to ESSingleNodeTestCase
nknize
force-pushed
the
feature/14713
branch
from
5123880 to
1885b6f
Compare
|
LGTM, thanks for the move to single node test! |
nknize
force-pushed
the
feature/14713
branch
from
1885b6f to
f5ba295
Compare
At the time of geo_shape query conception, CONTAINS was not yet a supported spatial operation in Lucene. Since it is now available this commit adds ShapeRelation.CONTAINS to GeoShapeQuery. Randomized testing is included and documentation is updated.
nknize
force-pushed
the
feature/14713
branch
from
f5ba295 to
0d34985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of
geo_shapequery conception,CONTAINSwas not yet a supported spatial operation in Lucene. Since it is now available this PR addsShapeRelation.CONTAINStoGeoShapeQuery. Randomized testing is included and documentation is updated.closes #14713
Backport closes #17866