Add callback for publication of new cluster state #15494
Conversation
This commit adds a callback for a cluster state task executor that will be invoked if the execution of a batch of cluster state update tasks led to a new cluster state and that new cluster state was successfully published. Closes #15482
| * Callback invoked after new cluster state is published. Note that | ||
| * this method is not invoked if the cluster state was not updated. | ||
| */ | ||
| default void clusterStatePublished(ClusterState newClusterState) { |
There was a problem hiding this comment.
I'm doubtful. I wonder if we should do this or follow the proven path we have in the listener interface where we have a processed callback (changed or not). I'm leaning towards the later as it gives more options (with the burden of an extra equality check).
There was a problem hiding this comment.
@bleskes I went back and forth, but opted for this simpler interface since for now the use case we have in mind doesn't need the callback on no change.
|
Left one comment. Do we also want to immediately use it for the shard state action? |
@bleskes Yes. I've a commit sitting locally pending the outcome of this pull request which I'll push to another pull request. |
|
LGTM |
…lback Add callback for publication of new cluster state
clintongormley
added
:Distributed Indexing/Distributed
This commit adds a callback for a cluster state task executor that will
be invoked if the execution of a batch of cluster state update tasks
led to a new cluster state and that new cluster state was successfully
published.
Closes #15482