Query and top level inner hit definitions shouldn't overwrite each other #16222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
force-pushed
the
inner_hits/top_level_definitions_should_not_overwrite_query_inner_hit_definitions
branch
2 times, most recently
from
ea8fd69 to
c18f783
Compare
|
LGTM |
martijnvg
force-pushed
the
inner_hits/top_level_definitions_should_not_overwrite_query_inner_hit_definitions
branch
2 times, most recently
from
86ba581 to
71a9809
Compare
martijnvg
force-pushed
the
inner_hits/top_level_definitions_should_not_overwrite_query_inner_hit_definitions
branch
from
71a9809 to
6c34452
Compare
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #16218