Reuse existing allocation id for primary shard allocation #16530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -411,13 +411,17 @@ void moveToUnassigned(UnassignedInfo unassignedInfo) { | |||
| /** | |||
| * Initializes an unassigned shard on a node. | |||
| */ | |||
| void initialize(String nodeId, long expectedShardSize) { | |||
| void initialize(String nodeId, String existingAllocationId, long expectedShardSize) { | |||
There was a problem hiding this comment.
can we document that the existingAllocationId can be null?
|
Left some very minor comments... |
ywelsch
force-pushed
the
fix/reuse-alloc-id
branch
2 times, most recently
from
d6ec6cd to
ed93ebe
Compare
|
@bleskes Thanks for the review! I've updated the PR according to your suggestions and made one additional change: I removed the overloads of the |
|
LGTM. Thanks @ywelsch |
ywelsch
force-pushed
the
fix/reuse-alloc-id
branch
from
ed93ebe to
94f19d7
Compare
ywelsch
pushed a commit
that referenced
this pull request
Feb 11, 2016
Reuse existing allocation id for primary shard allocation
lcawl
added
:Distributed Indexing/Distributed
clintongormley
added
:Distributed Coordination/Allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue where shard was activated by master but the cluster crashes before the target node persisted the shard state.
Relates to #14739