hide null-valued metadata fields from WriteableIngestDocument#toXContent #16557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>enhancement
v5.0.0-alpha1
:Data Management/Ingest Node
talevy
force-pushed
the
ingest_hide_null_metadata
branch
from
ee2ba69 to
f9453e5
Compare
|
LGTM |
talevy
added a commit
that referenced
this pull request
Feb 10, 2016
hide null-valued metadata fields from WriteableIngestDocument#toXContent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, null-valued metadata fields show up when rendering IngestDocuments in responses.
e.g.
{ "docs": [ { "processor_results": [ { "tag": "processor_2", "doc": { "_parent": null, "_timestamp": null, "_routing": null, "_id": "_id", "_index": "_index", "_ttl": null, "_type": "_type", "_source": { "flags": "new|hot|super|fun|interesting" }, "_ingest": { "timestamp": "2016-02-09T20:05:27.575+0000" } } }, ...This PR removes such values from the response, rendering the above as follows:
{ "docs": [ { "processor_results": [ { "tag": "processor_2", "doc": { "_index": "_index", "_id": "_id", "_type": "_type", "_source": { "flags": "new|hot|super|fun|interesting" }, "_ingest": { "timestamp": "2016-02-09T20:51:21.137+0000" } } }, ...