Fail closing or deleting indices during a full snapshot #17021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>enhancement
>breaking
review
:Distributed Coordination/Snapshot/Restore
|
I still don't think it's right to allow index deletion even for partial snapshots :) Other then that and the exception message that mentions partial snapshot, LGTM. |
ywelsch
force-pushed
the
fix/block-delete-on-snapshot
branch
from
dc01a5e to
266394c
Compare
ywelsch
added a commit
that referenced
this pull request
Mar 10, 2016
Fail closing or deleting indices during a full snapshot
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16321