Forbid test sources to use System.out.println and Throwable.printStackTrace #17112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +57,7 @@ | |||
| public static final List<String> LOGGER_METHODS = Arrays.asList("trace", "debug", "info", "warn", "error"); | |||
| public static final String IGNORE_CHECKS_ANNOTATION = "org.elasticsearch.common.SuppressLoggerChecks"; | |||
|
|
|||
| @SuppressForbidden(reason = "command line tool") | |||
There was a problem hiding this comment.
can you use the @ SuppressForbidden from lucene here? I think the test framework has dependencies on lucene no?
There was a problem hiding this comment.
The logger usage checker is a standalone tool. Its main sources have no dependencies besides ASM framework (its test sources reuse our test framework however). Just one additional "SuppressForbidden" beside the other 5 in the classpath ;-)
|
left one minor comment - LGTM otherwise, no need to re-review |
|
LGTM. |
ywelsch
added a commit
that referenced
this pull request
Mar 15, 2016
Forbid test sources to use System.out.println and Throwable.printStackTrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test sources have been exempt from the bundled forbiddenApi signatures
jdk-system-outthat check among others usages ofSystem.out.printlnandThrowable.printStackTrace. With the removal of benchmarks in #15356, there is no need to relax this check for tests anymore.This PR:
jdk-system-outchecks on all sources