Fix geo normalization for ranges and points #1998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geo normalization of latitude was not properly performed.
90°lat is the north pole, and +1°lat beyond is still the north pole,
not the south pole.
Latitude should not be wrapped like longitude but rather reflected,
accompanied with a +180°lon shift.
Normalizing ranges cannot be performed by normalizing its top-left
and bottom-right points, but must be split into multiple ranges.
And two "qeo"->"geo" type fixes as bonuses.
Note: There is still a problem with GeoPolygon, like for ranges,
but I'll fix this in a separate commit.
See elasticsearch/elasticsearch issue elastic#1997.
|
See #2024. |
|
see #3149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1997.