add ignore_missing option to convert,trim,lowercase,uppercase,grok,rename #20194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>enhancement
review
:Data Management/Ingest Node
talevy
force-pushed
the
ignore-missing
branch
from
c4a9a13 to
269955d
Compare
talevy
changed the title
| @@ -81,6 +96,10 @@ public Grok getGrok() { | |||
| return grok; | |||
| } | |||
|
|
|||
| public boolean isIgnoreMissing() { | |||
There was a problem hiding this comment.
the isIgnoreMissing getters are only used in tests, right? So then it can be package protected?
talevy
force-pushed
the
ignore-missing
branch
from
53e20f1 to
38c61f4
Compare
|
@martijnvg mind taking another look at this? |
talevy
changed the title
| /** | ||
| */ | ||
| public class IngestDocumentMatcher { | ||
| public static void assertIngestDocument(Object a, Object b) { |
There was a problem hiding this comment.
same note as in the json processor PR.
|
Small note, LGTM otherwise. |
talevy
force-pushed
the
ignore-missing
branch
3 times, most recently
from
f1aaf79 to
94710fc
Compare
talevy
added a commit
that referenced
this pull request
Sep 9, 2016
talevy
added a commit
that referenced
this pull request
Sep 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
ignore_missingoption for the Convert processor that will enable suppression of exceptions surrounding non-existant fields and null-valued fields.in response to: #19995
updated to include
TODO:
assertIngestDocumentsince it is not available to the ingest-common module