Skip to content

Add a hard limit for index.number_of_shard #20682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 29, 2016
Merged

Add a hard limit for index.number_of_shard #20682

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a0fbca8
Add a hard limit for `index.number_of_shard`
s1monw Sep 28, 2016
1eccd9d
apply review comments
s1monw Sep 28, 2016
936b52c
prefix system property with es.
s1monw Sep 29, 2016
79a6337
add unittest
s1monw Sep 29, 2016
b5dc9bd
add missing @suppress annotation
s1monw Sep 29, 2016
c2d77cc
use try catch to reset system property
s1monw Sep 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/main/java/org/elasticsearch/cluster/metadata/IndexMetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,16 @@ public static State fromString(String state) {
}
}

/* This is a safety limit that should only be exceeded in very rare and special cases. The assumption is that
* 99% of the users have less than 1024 shards per index. We also make it a hard check that requires restart of nodes
* if a cluster should allow to create more than 1024 shards per index. NOTE: this does not limit the number of shards per cluster.
* this also prevents creating stuff like a new index with millions of shards by accident which essentially kills the entire cluster
* with OOM on the spot.*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be reported in documentation too as a WARNING

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

private static final int MAX_NUMBER_OF_SHARDS = Integer.parseInt(System.getProperty("index.max_number_of_shards", "1024"));
public static final String INDEX_SETTING_PREFIX = "index.";
public static final String SETTING_NUMBER_OF_SHARDS = "index.number_of_shards";
public static final Setting<Integer> INDEX_NUMBER_OF_SHARDS_SETTING =
Setting.intSetting(SETTING_NUMBER_OF_SHARDS, 5, 1, Property.IndexScope);
Setting.intSetting(SETTING_NUMBER_OF_SHARDS, 5, 1, MAX_NUMBER_OF_SHARDS, Property.IndexScope);
public static final String SETTING_NUMBER_OF_REPLICAS = "index.number_of_replicas";
public static final Setting<Integer> INDEX_NUMBER_OF_REPLICAS_SETTING =
Setting.intSetting(SETTING_NUMBER_OF_REPLICAS, 1, 0, Property.Dynamic, Property.IndexScope);
Expand Down