Skip to content

Remove all date 'now' methods from Painless #20766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Conversation

jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Oct 5, 2016

As the title says.

This closes (#20762).

@jdconrad jdconrad changed the title Remove all date 'now' methods from the Painless Remove all date 'now' methods from Painless Oct 5, 2016
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some documentation about how to actually get now in a followup I think.

@rjernst
Copy link
Member

rjernst commented Oct 5, 2016

Lgtm. I don't think we need to document how to get now, as this is something people shouldn't be using in scripts. That is the entire reason for #20762.

@jdconrad
Copy link
Contributor Author

jdconrad commented Oct 5, 2016

I think @nik9000 might have meant document how to get the equivalent of now by passing it in as a param? @rjernst Thanks for the review.

@jdconrad jdconrad merged commit 8e27d74 into elastic:master Oct 5, 2016
jdconrad added a commit that referenced this pull request Oct 5, 2016
Remove all date 'now' methods from Painless
jdconrad added a commit that referenced this pull request Oct 5, 2016
Remove all date 'now' methods from Painless
@nik9000
Copy link
Member

nik9000 commented Oct 5, 2016

I think @nik9000 might have meant document how to get the equivalent of now by passing it in as a param?

Indeed.

@s1monw
Copy link
Contributor

s1monw commented Oct 5, 2016

w00t thanks for the quick reaction on this @jdconrad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants