Remove mention of params and lang on update action payload #21365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `params` and `lang` are properties on the object assigned to the `script` property on the payload, not top level properties themselves. Remove the mention of them for clarity. Add link to update documentation.
|
LGTM |
clintongormley
added
>docs
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@russcam Any reason why this wasn't merged? |
|
@russcam ping? |
|
Thanks for the ping, will merge now |
russcam
added a commit
that referenced
this pull request
Jun 13, 2017
Both `params` and `lang` are properties on the object assigned to the `script` property on the payload, not top level properties themselves. Remove the mention of them for clarity. Add link to update documentation. (cherry picked from commit 85ce6c0)
russcam
added a commit
that referenced
this pull request
Jun 13, 2017
Both `params` and `lang` are properties on the object assigned to the `script` property on the payload, not top level properties themselves. Remove the mention of them for clarity. Add link to update documentation. (cherry picked from commit 85ce6c0)
russcam
added a commit
that referenced
this pull request
Jun 13, 2017
Both `params` and `lang` are properties on the object assigned to the `script` property on the payload, not top level properties themselves. Remove the mention of them for clarity. Add link to update documentation. (cherry picked from commit 85ce6c0)
russcam
added a commit
that referenced
this pull request
Jun 13, 2017
Both `params` and `lang` are properties on the object assigned to the `script` property on the payload, not top level properties themselves. Remove the mention of them for clarity. Add link to update documentation. (cherry picked from commit 85ce6c0)
|
merged and backported to |
lcawl
added
:Distributed Indexing/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
paramsandlangare properties on the object assigned to thescriptproperty on the payload, not top level properties themselves. Remove the mention of them for clarity.Add link to update documentation.