Be strict when parsing values searching for booleans #21555
Conversation
This changes only the query parsing behavior to be strict when searching on boolean values. We continue to accept the variety of values during index time, but searches will only be parsed using `"true"` or `"false"`. Resolves elastic#21545
|
👍 I wonder if we can think about adding deprecation logging in 5.x for this somehow? |
|
That's the plan! |
Relates to elastic#21555, this is the deprecation logging for what was removed.
* Add deprecation logging for lenient boolean queries Relates to #21555, this is the deprecation logging for what was removed. * Make logger final and correct misspelled word
* master: (22 commits) Add proper toString() method to UpdateTask (#21582) Fix `InternalEngine#isThrottled` to not always return `false`. (#21592) add `ignore_missing` option to SplitProcessor (#20982) fix trace_match behavior for when there is only one grok pattern (#21413) Remove dead code from GetResponse.java Fixes date range query using epoch with timezone (#21542) Do not cache term queries. (#21566) Updated dynamic mapper section Docs: Clarify date_histogram bucket sizes for DST time zones Handle release of 5.0.1 Fix skip reason for stats API parameters test Reduce skip version for stats API parameter tests Strict level parsing for indices stats Remove cluster update task when task times out (#21578) [DOCS] Mention "all-fields" mode doesn't search across nested documents InternalTestCluster: when restarting a node we should validate the cluster is formed via the node we just restarted Fixed bad asciidoc in boolean mapping docs Fixed bad asciidoc ID in node stats Be strict when parsing values searching for booleans (#21555) Fix time zone rounding edge case for DST overlaps ...
|
Using RE-INDEX API I got the following error regarding this merge.
However there is no boolean field in any document of my index. |
|
@kmxillo I'd keep the discussion on https://discuss.elastic.co/t/reindexing-cant-parse-boolean-value-format-disabled-expected-true-or-false/80823/13. |
|
@kmxillo double checking a couple of things - this PR is strict in 6.0 but is a deprecation log in 5.x. Which version are you running against? (6.0 is not yet released). It would be great if you can reproduce it and open a new issue, with the mapping of the index and a document which causes this error? (note that the field value being parsed is |
clintongormley
added
:Search/Search
This changes only the query parsing behavior to be strict when searching on
boolean values. We continue to accept the variety of values during index time,
but searches will only be parsed using
"true"or"false".Resolves #21545