SuggestionBuilder doesn't need to extend ToXContentToBytes #22280
Conversation
This changes the class from extending the abstract class to implementing the ToXContent interface only. The former could lead to unexpected behaviour when trying to display the object, since the "toString()" method inherited from ToXContentToBytes would create an error message because the SuggestionBuilders toXContent() methods don't render complete json objects.
|
I'm seeing the same behavior with |
|
@ndimiduk thanks for your update on this, this PR only relates to SuggestionBuilder so if there are any issues with AggregationBuilder#toString() they might still be there. Would you mind opening a separate issue with a complete reproduction of your problem and which subtypes your are seeing this with? Since AggregationBuilders, like Suggestionbuilder, might only render fragments of the search request but currently relies on ToXContentToBytes#toString() to do this, there might still be issues. |
|
@cbuescher I just ran into this problem with a |
|
Hi, can you merge this fix to v2.4? |
Sorry, that version is long outdated and won't have any future releases, therefore it makes no sense merging anything there. |
This changes SuggestionBuilder from extending ToXContentToBytes to implementing the ToXContent interface only. The former could lead to unexpected behaviour when
trying to display instances of the object, since the inherited
toString()method would create an error message because the SuggestionBuilders toXContent() methods only render json fragments (see #22264 as an example).