Descriptions for scripting 'enabled' #22388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Script source settings` section currently states that `false` means scripting is ENABLED. The other sections seem to indicate that `false` means scripting is DISABLED. If the current documentation is correct, that would imply that `inline` and `stored` scripting are ENABLED by default, which seems to conflict with all the other sections in the document.
|
@daver208, you are right. I believe this fix is right. Can you sign the CLA? We need it to merge everything, including docs. |
|
Ok so signed, anyway to force the check again? Or will it resolve itself (I know how unlikely that is)... |
|
In a stroke of genius, any comment on an issue with an un-verified CLA forces the check again. I'll merge in a bit and backport where I can. |
nik9000
pushed a commit
that referenced
this pull request
Dec 30, 2016
The `Script source settings` section currently states that `false` means scripting is ENABLED. The other sections seem to indicate that `false` means scripting is DISABLED. If the current documentation is correct, that would imply that `inline` and `stored` scripting are ENABLED by default, which seems to conflict with all the other sections in the document.
nik9000
pushed a commit
that referenced
this pull request
Dec 30, 2016
The `Script source settings` section currently states that `false` means scripting is ENABLED. The other sections seem to indicate that `false` means scripting is DISABLED. If the current documentation is correct, that would imply that `inline` and `stored` scripting are ENABLED by default, which seems to conflict with all the other sections in the document.
nik9000
pushed a commit
that referenced
this pull request
Dec 30, 2016
The `Script source settings` section currently states that `false` means scripting is ENABLED. The other sections seem to indicate that `false` means scripting is DISABLED. If the current documentation is correct, that would imply that `inline` and `stored` scripting are ENABLED by default, which seems to conflict with all the other sections in the document.
|
No worries, conflicting documentation is worse than none at all... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Script source settingssection currently states thatfalsemeans scripting is ENABLED.The other sections seem to indicate that
falsemeans scripting is DISABLED.If the current documentation is correct, that would imply that
inlineandstoredscripting are ENABLED by default, which seems to conflict with all the other sections in the document.