Remove ParseFieldMatcher and ParseFieldMatcherSupplier #22581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
approved these changes
Jan 12, 2017
| } | ||
|
|
||
|
|
||
| public void testGetAggregatorFactories_returnsUnmodifiableList() { | ||
| public void testGetAggregatorFactories_returnsUnmodifiableList() { |
| String chiSquare = "\"chi_square\":{\"include_negatives\": " + includeNegatives + ", \"background_is_superset\":" | ||
| + backgroundIsSuperset + "}"; | ||
| assertEquals(new ChiSquare(includeNegatives, backgroundIsSuperset), | ||
| parseFromString(heuristicParserMapper, searchContext, chiSquare)); |
javanna
force-pushed
the
enhancement/remove_parse_field_matcher_last
branch
from
c47d464 to
eec7f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all of the remaining usages of
ParseFieldMatcherso that we can remove the class andParseFieldMatcherSupplier.Closes #19552