Consolidate some reindex utility classes #22666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything that extended `AbstractAsyncBulkByScrollAction` also extended `AbstractAsyncBulkIndexByScrollAction` so this removes `AbstractAsyncBulkIndexByScrollAction`, merging it into `AbstractAsyncBulkByScrollAction`.
jasontedor
approved these changes
Jan 18, 2017
tlrx
approved these changes
Jan 18, 2017
Almost entirely mechanical but a bit messy anyway. I hadn't do it for a while because it is so messy but if I'm going to move these into core I'd like to clean them up a bit first. |
nik9000
added a commit
that referenced
this pull request
Jan 18, 2017
Everything that extended `AbstractAsyncBulkByScrollAction` also extended `AbstractAsyncBulkIndexByScrollAction` so this removes `AbstractAsyncBulkIndexByScrollAction`, merging it into `AbstractAsyncBulkByScrollAction`.
|
Thanks for reviewing @tlrx and @jasontedor! |
lcawl
added
:Distributed Indexing/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything that extended
AbstractAsyncBulkByScrollActionalsoextended
AbstractAsyncBulkIndexByScrollActionso this removesAbstractAsyncBulkIndexByScrollAction, merging it intoAbstractAsyncBulkByScrollAction.I'd like to get this before doing #22616.