Disable graph analysis at query time for shingle and cjk filters producing tokens of different size #23920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucing tokens of different size Shingle filters that produce shingles of different size and CJK filters that produce bigram AND unigram are problematic when we analyze the graph they produce. The position for each shingle size are not aligned so each position has at least two side paths. So in order to avoid paths explosion this change disables the graph analysis at query time for field analyzers that contain these filters with a problematic configuration. Closes #23918
jimczi
added
:Search/Search
jimczi
changed the title
jpountz
reviewed
Apr 5, 2017
| builder.splitOnWhitespace(false); | ||
| Query query = builder.doToQuery(shardContext); | ||
| assertThat(expectedQuery, equalTo(query)); | ||
| } |
There was a problem hiding this comment.
should we also check that the correct query is built if the analyzer is sane and does not output unigrams?
|
@jpountz I pushed some changes to address your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shingle filters that produce shingles of different size and CJK filters that produce bigram AND unigram are problematic when
we analyze the graph they produce. The position for each shingle size are not aligned so each position has at least two side paths.
So in order to avoid paths explosion this change disables the graph analysis at query time for field analyzers that contain these filters
with a problematic configuration.
Closes #23918