Skip to content

Fix floating-point error when DateProcessor parses UNIX #24947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2017

Conversation

talevy
Copy link
Contributor

@talevy talevy commented May 30, 2017

DateProcessor's DateFormat UNIX format parser resulted in
a floating point rounding error when parsing certain stringed
epoch times. Now Double.parseDouble is used, preserving the
intended input.

DateProcessor's DateFormat UNIX format parser resulted in
a floating point rounding error when parsing certain stringed
epoch times. Now Double.parseDouble is used, preserving the
intented input.
@talevy talevy added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >bug labels May 30, 2017
@talevy talevy requested a review from martijnvg May 30, 2017 03:43
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy talevy merged commit 2a6e686 into elastic:master May 30, 2017
talevy added a commit that referenced this pull request May 30, 2017
DateProcessor's DateFormat UNIX format parser resulted in
a floating point rounding error when parsing certain stringed
epoch times. Now Double.parseDouble is used, preserving the
intented input.
@talevy talevy deleted the fix-date-error branch May 30, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v5.5.0 v6.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants