Skip to content

Remove usage of multi-types from the docs and added a page explaining type removal #25543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2017

Conversation

clintongormley
Copy link
Contributor

Closes #25401

@clintongormley clintongormley added the >docs General docs changes label Jul 4, 2017
@s1monw
Copy link
Contributor

s1monw commented Jul 4, 2017

LGTM for what it's worth

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -184,7 +184,7 @@ segments |1.4kb
|`segments.version_map_memory` |`svmm`, `segmentsVersionMapMemory` |No
|Memory used by version map |1.0kb
|`segments.fixed_bitset_memory` |`sfbm`, `fixedBitsetMemory` |No
|Memory used by fixed bit sets for nested object field types and type filters for types referred in _parent fields |1.0kb
|Memory used by fixed bit sets for nested object field types and type filters for types referred in `join fields |1.0kb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "`"?

@@ -1,89 +1,14 @@
[[default-mapping]]
=== `_default_` mapping

The default mapping, which will be used as the base mapping for any new
mapping types, can be customised by adding a mapping type with the name
deprecated[6.0.0,See <<removal-of-types>>]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@clintongormley
Copy link
Contributor Author

thanks @jpountz for the review

@clintongormley clintongormley merged commit 0170e0e into master Jul 5, 2017
@clintongormley clintongormley deleted the type_docs branch July 5, 2017 10:30
clintongormley added a commit that referenced this pull request Jul 5, 2017
jrodewig added a commit that referenced this pull request Oct 29, 2019
PR #25543 removed the `_uid` field in favor of the `_id` field,
including for use in slicing.

This removes an outdated reference to `_uid` in our reindex docs.
jrodewig added a commit that referenced this pull request Oct 29, 2019
PR #25543 removed the `_uid` field in favor of the `_id` field,
including for use in slicing.

This removes an outdated reference to `_uid` in our reindex docs.
jrodewig added a commit that referenced this pull request Oct 29, 2019
PR #25543 removed the `_uid` field in favor of the `_id` field,
including for use in slicing.

This removes an outdated reference to `_uid` in our reindex docs.
jrodewig added a commit that referenced this pull request Oct 29, 2019
PR #25543 removed the `_uid` field in favor of the `_id` field,
including for use in slicing.

This removes an outdated reference to `_uid` in our reindex docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants