Backport can_match endpoint to 5.6 to allow 6.0 to use the optimization in mixed version
#25704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
:Search/Search
colings86
approved these changes
Jul 13, 2017
| @@ -293,8 +295,18 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| public Builder addAggregators(AggregatorFactories factories) { | |||
| throw new UnsupportedOperationException("This needs to be removed"); | |||
| public boolean mustVisiteAllDocs() { | |||
There was a problem hiding this comment.
typo: mustVisiteAllDocs --> mustVisitAllDocs?
There was a problem hiding this comment.
ah that is also in master I will fix it there too
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Jul 13, 2017
With cross cluster search we can potentially proxy `can_match` requests to nodes that don't have the endpoint. This might not cause any problem from a functional perspecitve but will cause ugly error messages on the target node. This commit will cause an IAE if we try to talk to an incompatible node via a proxy. Relates to elastic#25704
…#25650) In certain situations we can early terminate and just skip the entire query phase or make the lucene level rewrite very cheap if we can already tell that a query won't match any documents. For instance if there is a single `match_none` ie. due to some range rewrite in a filter or must clause of a boolean query it can just drop all it's other queries since it will never match.
…tion in mixed version 6.0 applies some optimization to query rewriting if the number of shards is large. In oder to make use of this optimization this commit adds the internal endpoint to 5.6 such that a 6.0 coordinator node can make use of the feature even in a mixed cluster or via cross cluster search. Relates to elastic#25658
s1monw
force-pushed
the
backport_can_match
branch
from
d04500d to
9050c9e
Compare
s1monw
added a commit
that referenced
this pull request
Jul 13, 2017
With cross cluster search we can potentially proxy `can_match` requests to nodes that don't have the endpoint. This might not cause any problem from a functional perspecitve but will cause ugly error messages on the target node. This commit will cause an IAE if we try to talk to an incompatible node via a proxy. Relates to #25704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 applies some optimization to query rewriting if the number of shards
is large. In oder to make use of this optimization this commit adds the internal endpoint
to 5.6 such that a 6.0 coordinator node can make use of the feature even in a mixed cluster
or via cross cluster search.
Relates to #25658